Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Got TypeError when I ran the test. #31

Open
yusrepo opened this issue May 31, 2024 · 6 comments
Open

Got TypeError when I ran the test. #31

yusrepo opened this issue May 31, 2024 · 6 comments

Comments

@yusrepo
Copy link

yusrepo commented May 31, 2024

Dear developer,

Thanks for providing this amazing tool for HiC data modeling! After installation, I ran testing on the sample data, however, I got TypeError as follows. I also tried my own data and got similar error. Could you provide some clues as to where this error comes from and how to fix it? Thank you very much!

command: bash test.sh
Traceback (most recent call last):
File "/LOCALSTORE/L_Space/yuz/hichip/hic_public/miniMDS/scripts/../minimds.py", line 170, in
main()
File "/LOCALSTORE/L_Space/yuz/hichip/hic_public/miniMDS/scripts/../minimds.py", line 161, in main
structure = fullMDS(args.path, args.classical, args.a, args.n, args.w)
File "/LOCALSTORE/L_Space/yuz/hichip/hic_public/miniMDS/scripts/../minimds.py", line 43, in fullMDS
contactMat = dt.matFromBed(path, structure=structure)
TypeError: matFromBed() got an unexpected keyword argument 'structure'

@Lila14
Copy link
Contributor

Lila14 commented Jun 2, 2024

My apologies, I recently refactored, which broke some things. I've fixed this bug. Please pull the latest code and try again.

@Lila14 Lila14 closed this as completed Jun 2, 2024
@yusrepo
Copy link
Author

yusrepo commented Jun 4, 2024

Thanks for the prompt response! I ran the test on the latest version, and it seems the first command "python ../minimds.py hic_data/GM12878_combined_22_5kb.bed" works, however, the second command "python ../minimds.py --partitioned hic_data/GM12878_combined_22_5kb.bed" seems to be stuck and didn't not produce any output after 24 hours. I'm wondering if there's any problem with --partitioned feature? Thank you!

@Lila14 Lila14 reopened this Jun 9, 2024
@Lila14
Copy link
Contributor

Lila14 commented Jun 10, 2024

Thank you for spotting this. It was an issue with the parallelization library I used. I removed parallelization for now and will replace it with another library.

@yusrepo
Copy link
Author

yusrepo commented Jun 11, 2024

Screenshot 2024-06-11 at 3 52 15 PM

Thank you for the response! I tried minimds.py with my own data, and got the 3d model as I attached. The way I used this program is, first extract normalized intra-chromosome interactions to generate bed file for each chromosome, and then apply the minimds.py for each chromosome file to get a structure file, and use the plotting code you provided to visualize all chromosomes simultaneously. For the attached model I used 50k resolution, and only calculated intra-chromosome interactions. Just want to make sure with you, is it the correct way to use miniMDS? And if I use minimds_inter.py, will I got models that includes both inter- and intra-chromosome interactions? Thank you so much!

@Lila14
Copy link
Contributor

Lila14 commented Jun 11, 2024 via email

@yusrepo
Copy link
Author

yusrepo commented Jun 11, 2024

Thank you for the suggestions!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants