Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix --name-strategy serdes #72

Merged
merged 1 commit into from
May 22, 2024
Merged

fix --name-strategy serdes #72

merged 1 commit into from
May 22, 2024

Conversation

munishchouhan
Copy link
Member

This PR will add adapter to fix the serialization and deserialization of --name-strategy

@munishchouhan
Copy link
Member Author

fixes this error:

munish.chouhan@Munishs-MacBook-Pro wave-cli % ./app/build/native/nativeCompile/wave -i ubuntu --name-strategy imageSuffix
java.lang.AssertionError: Missing field in io.seqera.wave.api.ImageNameStrategy
        at com.squareup.moshi.StandardJsonAdapters$EnumJsonAdapter.<init>(StandardJsonAdapters.java:282)
        at com.squareup.moshi.StandardJsonAdapters$1.create(StandardJsonAdapters.java:68)
        at com.squareup.moshi.Moshi.adapter(Moshi.java:146)
        at com.squareup.moshi.ClassJsonAdapter$1.createFieldBindings(ClassJsonAdapter.java:145)
        at com.squareup.moshi.ClassJsonAdapter$1.create(ClassJsonAdapter.java:107)
        at com.squareup.moshi.Moshi.adapter(Moshi.java:146)
        at com.squareup.moshi.Moshi.adapter(Moshi.java:106)
        at com.squareup.moshi.Moshi.adapter(Moshi.java:80)
        at io.seqera.wave.cli.json.JsonHelper.toJson(JsonHelper.java:44)
        at io.seqera.wave.cli.Client.submit(Client.java:117)
        at io.seqera.wave.cli.App.run(App.java:446)
        at io.seqera.wave.cli.App.main(App.java:243)
        at java.base@21.0.2/java.lang.invoke.LambdaForm$DMH/sa346b79c.invokeStaticInit(LambdaForm$DMH)
Caused by: java.lang.NoSuchFieldException: none
        at java.base@21.0.2/java.lang.Class.checkField(DynamicHub.java:1041)
        at java.base@21.0.2/java.lang.Class.getField(DynamicHub.java:1026)
        at com.squareup.moshi.StandardJsonAdapters$EnumJsonAdapter.<init>(StandardJsonAdapters.java:278)
        ... 12 more

@pditommaso pditommaso merged commit eedd906 into master May 22, 2024
13 checks passed
@munishchouhan munishchouhan deleted the fix-image-strategy branch June 11, 2024 13:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants