Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix compatibility issues with old x86 machines #74

Merged
merged 2 commits into from
May 27, 2024
Merged

Fix compatibility issues with old x86 machines #74

merged 2 commits into from
May 27, 2024

Conversation

munishchouhan
Copy link
Member

This PR will resolve the issue of native-images with old x86 images

@munishchouhan munishchouhan linked an issue May 27, 2024 that may be closed by this pull request
Error while running wave-cli on x86 #73
Closed
@pditommaso
Copy link
Contributor

Nice. How to test it ?

@munishchouhan
Copy link
Member Author

Nice. How to test it ?

Igor who reported in slack, tested it and it works for him
https://nextflow.slack.com/archives/C0477AS31T5/p1716811520298989?thread_ts=1716806208.703459&cid=C0477AS31T5

I will test in current ubuntu to make sure that it doesn't break anything

@munishchouhan
Copy link
Member Author

Tested on Ubuntu 24.04 LTS with x86_64

$ ./wave --version
1.4.0_9a91533
$ ./wave --conda-package bwa  --wave-endpoint https://wave.dev-tower.net
wave.dev-tower.net/wt/d2a49fb81970/wave/build/dev:bwa--11cd60ae67b658b3

@pditommaso pditommaso merged commit 014154b into master May 27, 2024
3 checks passed
@munishchouhan munishchouhan deleted the 73-fix-compatibility-x86 branch May 27, 2024 13:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@pditommaso pditommaso pditommaso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error while running wave-cli on x86
2 participants
@munishchouhan @pditommaso