-
-
Notifications
You must be signed in to change notification settings - Fork 162
RunAsCLI()
swallows exceptions
#619
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Labels
Comments
|
You can change this behaviour by subclassing: import {Umzug, UmzugCLI, CommandLineParserOptions} from 'umzug'
class MyUmzugCLI extends UmzugCLI {
async execute() {
await super.executeWithoutErrorHandling()
return true
}
}
class MyUmzug extends Umzug {
getCLI(options?: CommandLineParserOptions) {
return new MyUmzugCLI(this, options)
}
}
const myUmug = new MyUmzug(...)
myUmzug.runAsCLI() |
Yep, I've already implemented. |
mmkal
added a commit
that referenced
this issue
Nov 6, 2023
mmkal
added a commit
that referenced
this issue
Nov 6, 2023
Released in v3.5.0-0. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
It looks like you use
execute()
from thets-command-whatever
library.Which silently swallows all exceptions by default.
Should be documented probably?
The text was updated successfully, but these errors were encountered: