Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[major] Add New Module: Quantum Transducer related #204

Open
wants to merge 39 commits into
base: master
Choose a base branch
from
Open

Conversation

caitaozhan
Copy link
Contributor

@caitaozhan caitaozhan commented Jan 3, 2025

New Component Modules from this paper: https://arxiv.org/pdf/2411.11377

  • Transducer
  • Transmon
  • FockDetector
  • FockBeamSplitter2

Also,

  • Added the unit tests in the folder tests
  • Added examples in the folder example/QuantumTransduction
  • Reorganized the AbsorptiveMemory related files
  • Update the requirements.txt
  • Update constants module
  • Update comments here and there

NOTE: work in progress.

  • Quantum Channel is not used
  • Scheduling events all at once and pass in class as argument instead of object

Copy link
Contributor

@Alex-Kolar Alex-Kolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. A couple other minor things I forgot to mention in the meeting this morning:

  1. Do we want to rename the QuantumTransduction and AbsorptiveMemory folders (and subfiles) to be snake case instead of camel case? This would match the rest of the project
  2. I don't remember if I mentioned this previously but it looks like the badges on the README/main github page are off center. Is it possible to fix this? I attached a photo.
    Screenshot 2025-01-17 at 12 09 29 PM

If these don't get changed, it's no big deal, just though I'd bring them up.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants