-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[major] Add New Module: Quantum Transducer related #204
Open
caitaozhan
wants to merge
39
commits into
master
Choose a base branch
from
RnD
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laura Quantum Transducer
…nts in the core code base.
…move the absorptive memory files to a new folder
…ockBeamSplitter2; delete custom_gate in Class Circuit; update comments and arguments
Alex-Kolar
reviewed
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. A couple other minor things I forgot to mention in the meeting this morning:
- Do we want to rename the
QuantumTransduction
andAbsorptiveMemory
folders (and subfiles) to be snake case instead of camel case? This would match the rest of the project - I don't remember if I mentioned this previously but it looks like the badges on the README/main github page are off center. Is it possible to fix this? I attached a photo.
If these don't get changed, it's no big deal, just though I'd bring them up.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Component Modules from this paper: https://arxiv.org/pdf/2411.11377
Transducer
Transmon
FockDetector
FockBeamSplitter2
Also,
tests
example/QuantumTransduction
AbsorptiveMemory
related filesrequirements.txt
constants
moduleNOTE: work in progress.