Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update credentials validation logic #20

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Update credentials validation logic #20

merged 1 commit into from
Dec 30, 2024

Conversation

ristokekovic
Copy link
Collaborator

What is the goal?

How is it being implemented?

  • Update the SeQura\Core\BusinessLogic\Domain\Connection\Models\ValidateConnectionRequest with the new request parameters
  • Update unit tests to reflect those changes

How is it tested?

  • Unit tests
  • Integration tests

@ristokekovic ristokekovic requested a review from m1k3lm December 27, 2024 09:25
@m1k3lm m1k3lm requested a review from mescalantea December 27, 2024 10:55
Copy link
Member

@m1k3lm m1k3lm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ristokekovic ristokekovic merged commit 801f446 into master Dec 30, 2024
1 check passed
@ristokekovic ristokekovic deleted the dev branch December 30, 2024 10:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants