misleading error message

[fmoor]

I was going through the serde_json :: de :: from_reader example and encountered an error at run time "KeyMustBeAString". I went back to my json file and looked. All of the keys were strings... I scratched my head and stared. Then I noticed that I had a trailing comma after the last value.

It seems like adding another error code that has something to do with trailing commas would make the error messages more human friendly.

test.json

{
  "fingerprint": "gray",
  "location": "1",
}

error message:

ErrorImpl { 
    code: KeyMustBeAString,
    line: 4,
    column: 1
 }

[dtolnay]

I agree! Would you be interested in implementing this? The code for parsing a map key will need to recognize when it gets a } and treat that as a trailing comma error.

[fmoor]

I'll give it a go.

[fmoor]

Is there documentation on contributing? It seems like the tests don't compile on rustc stable...

[fmoor]

I switched to nightly and the tests compile with warnings about unused extern crate. Only a hand full of tests run and they all fail. What gives?

rustc 1.21.0-nightly (7eeac1b81 2017-08-30)
cargo 0.22.0-nightly (3d3f2c05d 2017-08-27)

[fmoor]

Further study of travis.sh revealed that I was missing a build step

(cd "$DIR/tests/deps" && channel build)

All tests seem to be passing. On to the real work.