Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Use serialize_entry instead of serialize_key + serialize_value when serialize flatten newtype enum variant #2785

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Use serialize_entry instead of serialize_key + serialize_value when serialize flatten newtype enum variant #2785

merged 1 commit into from
Aug 5, 2024

Conversation

Mingun
Copy link
Contributor

@Mingun Mingun commented Aug 3, 2024

Serializers that reimplements serialize_entry will get benefits from that

@Mingun
Use serialize_entry instead of serialize_key + serialize_value when s…
bc5af50 
…erialize flatten newtype enum variant

Serializers that reimplements serialize_entry will get benefits from that
dtolnay
dtolnay approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay dtolnay merged commit e08c5de into serde-rs:master Aug 5, 2024
15 checks passed
@Mingun Mingun deleted the serialize_entry-in-flatten-newtype-variant branch August 5, 2024 08:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mingun @dtolnay