Fix upload editors not showing the errors returned from TemporaryUplo…

…ad, and assuming upload successful even when it is not due to blacklist or some other validation error
serenity-is · Jun 5, 2024 · f61bb96 · f61bb96
1 parent 54e26bb
commit f61bb96
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/packages/corelib/src/ui/helpers/uploadhelper.ts b/packages/corelib/src/ui/helpers/uploadhelper.ts
@@ -36,7 +36,14 @@ export namespace UploadHelper {
 
         new Uploader({
             batchSize: 1,
-            batchSuccess: data => options.fileDone?.(data.response ?? {}, data.batch?.filePaths?.[0], data),
+            batchSuccess: data => {
+                const response: UploadResponse = data.response ?? {};
+                if (response?.Error) {
+                    notifyError(response.Error.Message);
+                    return;
+                } 
+                options.fileDone?.(response, data.batch?.filePaths?.[0], data);
+            },
             input: uploadInput.getNode() as HTMLInputElement,
             dropZone: options.zone,
             batchStart: () => {