Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix null error in InstallationContextConfig #2917

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Fix null error in InstallationContextConfig #2917

merged 2 commits into from
Jul 19, 2024

Conversation

ValgulNecron
Copy link
Contributor

Added #[serde(default)] to oauth2_install_params in InstallationContextConfig and added a Default implementation to InstallParams #2883 and https://discord.com/developers/docs/resources/application#application-object-application-structure.

Added #[serde(default)] to oauth2_install_params in InstallationContextConfig and added a Default implementation to InstallParams
#2883 and https://discord.com/developers/docs/resources/application#application-object-application-structure.
@github-actions github-actions bot added the model Related to the `model` module. label Jul 15, 2024
@mkrasnitski
Copy link
Collaborator

mkrasnitski commented Jul 18, 2024

Since CurrentApplicationInfo::integration_types_config is gated behind unstable_discord_api, it's actually ok to break the serenity API and change its oauth2_install_params field to Option<InstallParams>.

reverted back the change I made in the last commit and wrapped InstallParams in an Option
@ValgulNecron
Copy link
Contributor Author

Hi thanks for the info i changed it to an option and removed the change I made before

@arqunis arqunis added the fix A solution to an existing bug. label Jul 19, 2024
@arqunis arqunis merged commit b234d04 into serenity-rs:current Jul 19, 2024
22 checks passed
fenhl added a commit to dasgefolge/peter-discord that referenced this pull request Aug 5, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
fix A solution to an existing bug. model Related to the `model` module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants