-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add missing fields to CurrentApplicationInfo #2939
Conversation
Added approximate_guild_count and approximate_user_install_count to CurrentApplicationInfo https://discord.com/developers/docs/resources/application#application-object-application-structure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These values are never going to exceed 4 billion, so should be u32
s.
i changed the type to u32 |
Sure, if you want. |
well don't really know what the lint issue. since i don't get it on my side (maybe older rust version) |
Read the command run, it isn't a check or clippy, it's |
well just found the issue but it change 213 file. i guess something wrong with my setup |
When I said "run |
As per the discord docs https://discord.com/developers/docs/resources/application#application-object-application-structure application contain approximate_guild_count and approximate_user_install_count.
approximate_user_install_count was recently added discord/discord-api-docs@9c45aa7
but approximate_guild_count seem to have been missed.
there's also guild, redirect_uris, interactions_endpoint_url which according to the doc are in the application but not given by serenity, I didn't add them because I didn't need them and they seem to be older and either ignored on purpose or forgotten.