Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add missing fields to CurrentApplicationInfo #2939

Merged
merged 5 commits into from
Aug 16, 2024

Conversation

ValgulNecron
Copy link
Contributor

As per the discord docs https://discord.com/developers/docs/resources/application#application-object-application-structure application contain approximate_guild_count and approximate_user_install_count.

approximate_user_install_count was recently added discord/discord-api-docs@9c45aa7

but approximate_guild_count seem to have been missed.

there's also guild, redirect_uris, interactions_endpoint_url which according to the doc are in the application but not given by serenity, I didn't add them because I didn't need them and they seem to be older and either ignored on purpose or forgotten.

@github-actions github-actions bot added the model Related to the `model` module. label Aug 16, 2024
Copy link
Member

@GnomedDev GnomedDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These values are never going to exceed 4 billion, so should be u32s.

@ValgulNecron
Copy link
Contributor Author

i changed the type to u32
before merging should i add the 3 other fields that are not present ?

@GnomedDev
Copy link
Member

Sure, if you want.

@ValgulNecron
Copy link
Contributor Author

well don't really know what the lint issue. since i don't get it on my side (maybe older rust version)

@GnomedDev
Copy link
Member

Read the command run, it isn't a check or clippy, it's fmt. You have to run cargo +nightly fmt.

@ValgulNecron
Copy link
Contributor Author

well just found the issue but it change 213 file. i guess something wrong with my setup

@GnomedDev
Copy link
Member

When I said "run cargo +nightly fmt" I meant it, you most likely forgot to type +nightly.

@GnomedDev GnomedDev changed the title Added approximate_guild_count and approximate_user_install_count to CurrentApplicationInfo Add missing fields to CurrentApplicationInfo Aug 16, 2024
@GnomedDev GnomedDev merged commit c28c25e into serenity-rs:current Aug 16, 2024
22 checks passed
ivinjabraham pushed a commit to ivinjabraham/serenity that referenced this pull request Aug 29, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
model Related to the `model` module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants