Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Stablise User Apps #3018

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

GnomedDev
Copy link
Member

Applies changes from https://discord.com/developers/docs/change-log#userinstalled-apps-general-availability and removes the unstable flags.

Closes #2967

@github-actions github-actions bot added model Related to the `model` module. builder Related to the `builder` module. labels Nov 6, 2024
@GnomedDev GnomedDev force-pushed the stablise-user-apps branch 2 times, most recently from 960d6d4 to 3bb030b Compare November 6, 2024 22:35
jamesbt365
jamesbt365 previously approved these changes Nov 7, 2024
Copy link
Member

@jamesbt365 jamesbt365 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simd-json feature is cooked here but I think this is okay (other than failing tests), tested it on a command it seems to deserialize just fine. Unsure specifically how to test the Component and ModalSubmit paths so they remain untested at this time.

@arqunis arqunis added enhancement An improvement to Serenity. discord feature Related to Discord's functionality. labels Nov 9, 2024
@GnomedDev GnomedDev merged commit 17172da into serenity-rs:current Nov 11, 2024
22 checks passed
@GnomedDev GnomedDev deleted the stablise-user-apps branch November 11, 2024 21:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
builder Related to the `builder` module. discord feature Related to Discord's functionality. enhancement An improvement to Serenity. model Related to the `model` module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make user apps stable
4 participants