Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add support for Entry Point commands #3021

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

mkrasnitski
Copy link
Collaborator

The discord docs are a little confusing for this feature, but I think it's basically pretty simple. Applications with activities enabled can define a global command of type PrimaryEntryPoint - based on the value of the handler field, this command can be treated essentially like normal, allowing the application to respond with a followup message when called; or, the behavior of the command can be automatically handled by Discord.

@github-actions github-actions bot added model Related to the `model` module. builder Related to the `builder` module. labels Nov 8, 2024
Copy link
Member

@GnomedDev GnomedDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpick, but otherwise good to merge.

Comment on lines +67 to +70
/// Not valid for autocomplete and Ping interactions. Only available for applications with
/// Activities enabled.
///
/// Responds to the interaction by launching the Activity associated with the app.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can these lines be flipped? Seems to be backwards.

Copy link
Collaborator Author

@mkrasnitski mkrasnitski Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mirrors the docs for the other variants, like Acknowedge, UpdateMessage, Autocomplete, and Modal. If this should be changed, I think the others should too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, no worries then.

@GnomedDev GnomedDev merged commit 85df0b0 into serenity-rs:current Nov 11, 2024
22 checks passed
@mkrasnitski mkrasnitski deleted the entry-point-commands branch November 12, 2024 01:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
builder Related to the `builder` module. model Related to the `model` module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants