Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix typings with ESM #32

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix typings with ESM #32

wants to merge 1 commit into from

Conversation

flaviut
Copy link

@flaviut flaviut commented Oct 19, 2022

Without this change, I get this error:

serial.ts:1:49 - error TS7016: Could not find a declaration file for module '@serialport/bindings-interface'. '.../node_modules/@serialport/bindings-interface/dist/index-esm.mjs' implicitly has an 'any' type.

Once this change is made, everything typechecks correctly.

@CalmDownVal CalmDownVal mentioned this pull request Sep 16, 2023
Open
@Azq2 Azq2 mentioned this pull request Apr 27, 2024
Closed
@Azq2
Copy link

Azq2 commented Apr 27, 2024

@reconbot any reasons why this fix is not merged? :(

@TheFissk
Copy link

Could we please get this fix merged.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flaviut @Azq2 @TheFissk