-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Move SerilogLoggerFactory to Serilog.Extensions.Logging #53
Labels
Comments
It could be moved and type-forwarded, since this package already depends on Serilog.Extensions.Logging 😊 |
I'll happily take this task (unless of course someone else comes along and does the hard work) |
@ChrisSimmons What's the status of this? |
This is part of serilog/serilog-extensions-logging#132 |
5 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
From a distance, it seems that while
SerilogWebHostBuilderExtensions
deals with bona fide ASP.NET concerns (e.gIWebHostBuilder
),SerilogLoggerFactory
would be better placed in a more generic .NET Core library. PerhapsSerilog.Extensions.Logging
.There's also the possibility that I'm completely insane. :)
Of course if not, I realize this would be a breaking change but maybe something to consider in the next major version of this library.
The text was updated successfully, but these errors were encountered: