Integrate with LoggerProviderCollection #87
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will integrate
UseSerilog()
with theILoggerProvider
support in upstream Serilog.Extensions.Logging.For the more self-contained (post-IoC-initialization) variant, it'll be as simple as
UseSerilog(writeToProviders: true)
.When logging is configured first, at program startup, a
LoggerProviderCollection
will need to be constructed and passed toWriteTo.Providers()
as well asUseSerilog()
.For some context, this will enable usage like: opentracing-contrib/csharp-netcore#42
Resolves #53
@andrewlock I'm hoping this will translate cleanly across to Serilog.Extensions.Hosting, and once we're happy with it here, I'll assemble a second PR :-)
TestsTurns out there isn't really any (sanely) testable implementation in this package, it's all now in Serilog.Extensions.LoggingShould the secondNo :-)UseSerilog()
overload default to writing to providers?