Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

README and sample updates for v3.0 #95

Closed
2 of 4 tasks
nblumhardt opened this issue Jun 25, 2019 · 6 comments
Closed
2 of 4 tasks

README and sample updates for v3.0 #95

nblumhardt opened this issue Jun 25, 2019 · 6 comments
Labels

Comments

@nblumhardt
Copy link
Member

nblumhardt commented Jun 25, 2019

Once v3.0 of this project ships, we should show use of IHostBuilder through Serilog.Extensions.Hosting instead of the IWebHostBuilder code we continue to support here for backward compatibility. There are also some new features to document.

  • Update the README and samples here to use IHostBuilder and current ASP.NET Core conventions
  • Update the Serilog.Extensions.Hosting README to replicate the more detailed information about early vs. inline initialization, and provider support, currently documented in this project
  • Add documentation for IDiagnosticContext
  • Include Debug, Console, and File sinks as dependencies, with example usage in the README; Settings.Configuration may also be worth consideration
@carlowahlstedt
Copy link

Not sure if this is for compatibility with Core 3, but enabling Serilog is eating the output to the debug console after upgrading. Here's my Program.cs post upgrade where I had to comment out Serilog to get the output to the debug console to work.

image

I couldn't find any other way to enable Serilog with the extension method, docs, or anything else that gave be an idea of what I might be doing wrong.

@nblumhardt
Copy link
Member Author

Thanks for the heads-up. You need WriteTo.Debug() in your Serilog configuration if you want log events to go to the debug console (dotnet add package Serilog.Sinks.Debug) - it wouldn't hurt if we take a dependency on this and the console sink from this package, I'll make that change and include this info in the README. Cheers!

@carlowahlstedt
Copy link

Thanks for the quick response. I only noticed because opening of the browser window in vs code stopped working after the update. Finally tracked it back to that.

@rogerfar
Copy link

rogerfar commented Sep 9, 2019

Is there an upgrade path needed from 2.x to 3.0? It looks like the CHANGES.MD isn't kept up to date.

@nblumhardt
Copy link
Member Author

Hi @rogerfar - thanks for pointing out the unmaintained CHANGES.md. I've just deleted it - changes are now tracked per release in https://github.com/serilog/serilog-aspnetcore/releases

There are no API-breaking changes in v3.0, though some functionality has moved around between packages under the hood.

If you encounter any issues upgrading, let us know, we'll pop some notes into the 3.0.0 milestone release notes. Thanks!

@nblumhardt
Copy link
Member Author

#111 is tracking the last of the example changes.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants