Dependency and README updates #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merbla
reviewed
Aug 18, 2019
| @@ -21,6 +21,7 @@ public static int Main(string[] args) | |||
| Log.Logger = new LoggerConfiguration() | |||
| .ReadFrom.Configuration(Configuration) | |||
| .Enrich.FromLogContext() | |||
| .WriteTo.Debug() | |||
There was a problem hiding this comment.
I like this, there are lots of questions when folks are getting started that this may help.
|
The reason I left this in draft is that it will update the README in a way that's incompatible with the current released package. We could just jump ahead, however, and release our 3.0 with the framework dependencies left at 2.2 (it doesn't look like we'll bump dependency versions this time around). Thoughts? |
|
|
Will just need: serilog/serilog-extensions-hosting#11 |
|
Planning to merge and release this via 3.0.0, and only merge the example updates in #111 once .NET Core 3 has shipped. |
This was referenced Aug 27, 2019
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
Console,Debug, andFilesinks to the package dependencies, along with Serilog.Formatting.Compact (JSON) and Serilog.Settings.Configuration. The README is updated accordingly.The goal is to make the onboarding process smoother. There's still work to do, including sample updates to match the ASP.NET Core 3.0 hosting startup.
Partial #95