Ability to customize LogEventLevel used in UseSerilogRequestLogging middleware #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eware FEATUREL add new dependency injection overloads to offer more flexibility while configuring options
seroche
changed the title
nblumhardt
reviewed
Sep 17, 2019
added 2 commits
September 17, 2019 16:18
FEATURE: use default empty overload in sample FEATURE: rename GetLogEventLevel to GetLogLevel
nblumhardt
reviewed
Sep 17, 2019
…standards REFACTORING: renamed GetLogLevel to GetLevel
|
Hopefully this should be good now :) |
nblumhardt
reviewed
Sep 20, 2019
… is useful when an exception is thrown but HttpStatusCode is not yet set to 500 InternalServerError FIX: DefaultGetLevel now returns Error if there is an exception OR if StatusCode > 499
|
Hello, any plan to merge this soon? |
|
Done! Thanks. I think if I get a chance I'll investigate adding |
This was referenced Oct 2, 2019
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FEATURE: add ability to customize the LogEventLevel used by the middleware
FEATURE: add new dependency injection overload to offer more flexibility while configuring options