Update Instructions for .NET Core 3 templates #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The instructions for using Serilog contained statements that were no longer valid since .NET Core 3.0 uses the Generic Host and new project templates. The code sample in the readme and the corresponding statements were updated to resemble these changes.
|
I think that probably it would be a good idea to inlcude the instructions for users that are still on pre .NET Core 3 versions. But as it seems to me the readme file resembles the instructions for the latest version, and as the templates vary also for example from .NET Core 2.0 to 2.1, this could make the readme somewhat unclear? I'm a little unsure about we should do and how we do it, so I really would like to know what you're thinking. |
|
I think it's worthwhile moving the examples forwards, since 3.x is now well-and-truly established. Thanks! |
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #147
The instructions for using Serilog contained statements that were no longer valid since .NET Core 3.0 uses the Generic Host and new project templates.
The code sample in the readme and the corresponding statements were updated to resemble these changes.