Allow an ILogger to be specified

[nblumhardt]

Resolves #182

[sungam3r]

https://github.com/serilog/serilog-aspnetcore/blob/dev/src/Serilog.AspNetCore/SerilogWebHostBuilderExtensions.cs#L146

I think it is worth to use DI provided features. Why to manually specify logger if it is already exists ? Just add new ctor param:

 public RequestLoggingMiddleware(RequestDelegate next, DiagnosticContext diagnosticContext, RequestLoggingOptions options, ILogger logger)

[dazinator]

@sungam3r - what about if serilog ILogger is not registered for DI and the developer is only using Log.Logger everywhere - which i may be wrong, but is a valid style for using serilog?

[sungam3r]

Well, then we can use second RequestLoggingMiddleware ctor with ILogger property inside options to satisfy both categories.

[nblumhardt]

Thanks for the feedback @sungam3r - will give it some thought 👍

[pnmcosta]

Any prediction when this might be merged? Thanks.

[nblumhardt]

@pnmcosta still needs some thought, sorry. I like the idea of accepting the logger as a constructor parameter, but I'm not sure whether this covers all scenarios 🤔

[pnmcosta]

@nblumhardt my scenario is that we built a library that extends Serilog with our own conventions, and we expose our own singleton for the root logger, not relying on Serilog's.

We also only leverage DI for MS's ILogger's, i'm not even sure if internally Serilog.Ilogger's are registered in the container, but in our case we don't need the Serilog.ILogger in the container.

From a consuming point of view, I'd definitely be more inclined to set the logger on the options, unless UseSerilog does it for us, as I am setting our singleton there.

HTH