Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Throw for missing configured assemblies only when required #391

Merged
merged 1 commit into from
Aug 5, 2023
Merged

Throw for missing configured assemblies only when required #391

merged 1 commit into from
Aug 5, 2023

Conversation

0xced
Copy link
Member

@0xced 0xced commented Aug 4, 2023

Fixes #389

This was referenced Aug 4, 2023
Closed
Closed
nblumhardt
nblumhardt approved these changes Aug 5, 2023
View reviewed changes
Copy link
Member

@nblumhardt nblumhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@skomis-mm skomis-mm merged commit dd62cab into serilog:dev Aug 5, 2023
@0xced 0xced deleted the reduce-throw branch August 8, 2023 21:40
@0xced 0xced mentioned this pull request Aug 21, 2023
Closed
@nblumhardt nblumhardt mentioned this pull request Aug 21, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@nblumhardt nblumhardt nblumhardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Serilog:Using Check Seems Unnecessarily Restrictive
3 participants
@0xced @nblumhardt @skomis-mm