Use consistent binding logic for nested properties in object argument values #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nblumhardt
commented
Aug 3, 2024
| } | ||
|
|
||
| [Fact] | ||
| public void ConstructsNestedComplexObjects() |
There was a problem hiding this comment.
Relevant test case is this one :-)
|
Thanks @nblumhardt, I have tested your PR on my case and it seems to work great. Hopefully it will be included in the next release :) |
|
Great! Thanks for the feedback @MrPsi. I'll leave this open a few more days in case there's some feedback to come, but should get a dev build out soon. |
|
Hi @nblumhardt, do you have any indicatation when the next release will be containing this merge? |
Merged
|
8.0.3 is out now; thanks @ArieGato 👍 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #417
When an argument value is a complex object, instead of deferring to
Microsoft.Extensions.Configurationwe'll now recursively use the same logic to construct its properties that we do when constructing the object itself. This means that values accepted for constructor parameters and method arguments now line up with those accepted for property setters.This should allow for some simplification of the rest of
ObjectArgumentValueonce we've shaken out any issues.Thanks for your patience and effort narrowing this down, @MrPsi - sorry it took a while to get back around to it! I think the limitation here is the one to fix, so if/when this is merged I think it will supersede serilog/serilog-sinks-email#131.