Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add note about new required Webpack peer dependency to README #138

Closed
HyperBrain opened this issue Jul 2, 2017 · 2 comments · Fixed by #140
Closed

Add note about new required Webpack peer dependency to README #138

HyperBrain opened this issue Jul 2, 2017 · 2 comments · Fixed by #140

Comments

@HyperBrain
Copy link
Member

This is a Feature Proposal

Description

PR #83 which already has been merged to master is a breaking change. It offers users to use the webpack version of their choice, which is really helpful, but demands a change of the project dependencies, i.e. projects using the upcoming version must install a webpack version through their dependencies.

From a versioning perspective the upcoming version will be 2.0.0 then, to not break existing installations.

We should add a note to the README, that informs people about this change and its availability in version 2.0.0.

@HyperBrain
Copy link
Member Author

Imo the note should be placed somewhere at the top of the README, so that it is seen on a first glance when opening the npmjs page or GitHub.

@hassankhan
Copy link
Contributor

#140 ready for review 👍

HyperBrain added a commit that referenced this issue Jul 2, 2017
Add a note about breaking change in v2. Fixes #138
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants