Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Do not add .js extension to entries values #166

Closed
wants to merge 1 commit into from
Closed

Do not add .js extension to entries values #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/validate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@ const _ = require('lodash');

function getEntryForFunction(serverlessFunction) {
const handler = serverlessFunction.handler;
const handlerFile = /(.*)\..*?$/.exec(handler)[1] + '.js';
const handlerFile = /(.*)\..*?$/.exec(handler)[1];

// Create a valid entry key
return {
[handlerFile]: `./${handlerFile}`
[`${handlerFile}.js`]: `./${handlerFile}`
};
};

Expand Down
10 changes: 5 additions & 5 deletions tests/validate.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,10 +277,10 @@ describe('validate', () => {
.then(() => {
const lib = require('../lib/index');
const expectedLibEntries = {
'module1.js': './module1.js',
'module2.js': './module2.js',
'handlers/func3/module2.js': './handlers/func3/module2.js',
'handlers/module2/func3/module2.js': './handlers/module2/func3/module2.js',
'module1.js': './module1',
'module2.js': './module2',
'handlers/func3/module2.js': './handlers/func3/module2',
'handlers/module2/func3/module2.js': './handlers/module2/func3/module2',
};

expect(lib.entries).to.deep.eq(expectedLibEntries)
Expand All @@ -305,7 +305,7 @@ describe('validate', () => {
.then(() => {
const lib = require('../lib/index');
const expectedLibEntries = {
'module1.js': './module1.js'
'module1.js': './module1'
};

expect(lib.entries).to.deep.eq(expectedLibEntries)
Expand Down