Do not let lodash parse module names as path elements #252
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Closes #251
How did you implement it:
Use full module name as property name and do not insert it into path elements used by lodash.
The previous implementation led to lodash splitting module names with dots to use them as paths.
How can we verify it:
Use a project with a dependency that contains a dot in its name.
The project should be packaged correctly, including the "dotted" dependency.
Todos:
Is this ready for review?: YES
Is it a breaking change?: NO