Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Do not let lodash parse module names as path elements #252

Merged
merged 1 commit into from
Oct 11, 2017

Conversation

HyperBrain
Copy link
Member

@HyperBrain HyperBrain commented Oct 10, 2017

What did you implement:

Closes #251

How did you implement it:

Use full module name as property name and do not insert it into path elements used by lodash.
The previous implementation led to lodash splitting module names with dots to use them as paths.

How can we verify it:

Use a project with a dependency that contains a dot in its name.
The project should be packaged correctly, including the "dotted" dependency.

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@HyperBrain HyperBrain merged commit f47c348 into master Oct 11, 2017
@HyperBrain HyperBrain deleted the fix-modules-with-full-stop branch October 11, 2017 08:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.1.1 dropping some dependencies.
1 participant