Exclude node_modules completely if deploying to google cloud functions, as GCF installs package.json. #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @debanjanbasu , thank you for the PR. Can you fill out the description template completely - especially the checkboxes and check "enable edits from maintainers" in your PR? |
HyperBrain
requested changes
Oct 30, 2017
lib/packExternalModules.js
Outdated
| }); | ||
| // Copy modules only if not google-cloud-functions | ||
| // GCF Auto installs the package json | ||
| if (_.get(this.serverless, 'service.provider.name') !== 'google') { |
There was a problem hiding this comment.
I would prefer an early exit here if the provider is google instead of putting the default case into the if.
if (_.get(this.serverless, 'service.provider.name') === 'google') {
return BbPromise.resolve();
}
...
There was a problem hiding this comment.
Updated this. I will add unit tests for the new behavior to restore coverage.
HyperBrain
approved these changes
Oct 31, 2017
|
@debanjanbasu May I ask you for a favor? There is still the column for GCF missing in the provider compatibility chart (README). Would you mind to prepare a PR that adds the GCF status to the README? |
jamesmbourne
pushed a commit
to jamesmbourne/serverless-webpack
that referenced
this pull request
Oct 15, 2019
Exclude node_modules completely if deploying to google cloud functions, as GCF installs package.json.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exclude node_modules completely if deploying to google cloud functions, as GCF installs package.json.
Added a check to see if the provider is Google
How can we verify it:
Todos:
Is this ready for review?: YES
Is it a breaking change?: NO