Set target to 'node' if not specified by the configuration. #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmbourne
pushed a commit
to jamesmbourne/serverless-webpack
that referenced
this pull request
Oct 15, 2019
…efault-target Set target to 'node' if not specified by the configuration.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Closes #276
How did you implement it:
Trivial change: Set target to 'node' in case it is not set in the configuration.
Added unit tests.
How can we verify it:
Supply a webpack configuration without the target property. It should be set to 'node' automatically and a Serverless service should deploy and run correctly (especially the environment variables which break if the target is not set in the webpack compiler).
Todos:
[ ] Write documentationnot relevantIs this ready for review?: YES
Is it a breaking change?: NO