Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix babel example #320

Merged

Conversation

pcowgill
Copy link
Contributor

@pcowgill pcowgill commented Feb 6, 2018

What did you implement:

Removed the babel example that was always worse than the babel-dynamically-entries example, and renamed babel-dynamically-entries to babel. Also added READMEs.

How did you implement it:

How can we verify it:

All you need to do is glance at the deletion, renaming, and README addition in the PR itself. Because of the renaming of one example to what had been the name of another, it's easier to look at each individual commit rather than the diff for the whole PR.

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

Copy link
Member

@HyperBrain HyperBrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Especially with the warning in the static example it should now make things clear for everyone trying the project for the first time.

@HyperBrain HyperBrain added this to the 4.3.0 milestone Feb 6, 2018
@HyperBrain HyperBrain merged commit dc51648 into serverless-heaven:master Feb 6, 2018
@pcowgill pcowgill deleted the feature/fix-babel-example branch February 7, 2018 15:57
jamesmbourne pushed a commit to jamesmbourne/serverless-webpack that referenced this pull request Oct 15, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants