Purge handler module from require cache on watch #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyperBrain
commented
Mar 20, 2018
lib/utils.js
Outdated
| if (!_.includes(visitedModules, mod)) { | ||
| visitedModules.push(mod); | ||
| _.forEach(mod.children, function (child) { | ||
| traverse(child); |
There was a problem hiding this comment.
To prevent stackoverflows I'll replace the recursive implementation with an iterative one (breadth or depth first search does not matter here).
HyperBrain
force-pushed
the
fix-local-invoke-watch
branch
from
702d3b3 to
68d649b
Compare
jamesmbourne
pushed a commit
to jamesmbourne/serverless-webpack
that referenced
this pull request
Oct 15, 2019
…ocal-invoke-watch Purge handler module from require cache on watch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Closes #349
How did you implement it:
Before Serverless requires the handler, we purge any loaded ones from the require cache.
This forces Serverless to load a fresh handler from file, which is needed in case a watch compile happened. Otherwise the old module from the initial compile will be used.
How can we verify it:
npx sls invoke local --function=XXXX --path=some-event.json --watchTodos:
Write documentation(N/A)Is this ready for review?: YES
Is it a breaking change?: NO