Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update the out-dated documentation #354

Merged
merged 1 commit into from
Mar 21, 2018
Merged

Update the out-dated documentation #354

merged 1 commit into from
Mar 21, 2018

Conversation

posquit0
Copy link
Contributor

What did you implement:

serverless-webpack already support packager option in serverless.yml file. So, the comment in README.md should be updated.

How did you implement it:

How can we verify it:

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@HyperBrain
Copy link
Member

@posquit0 Nice catch 👍 . I missed that one.

@HyperBrain HyperBrain added this to the 5.1.1 milestone Mar 21, 2018
@HyperBrain HyperBrain merged commit 120038f into serverless-heaven:master Mar 21, 2018
@posquit0 posquit0 deleted the patch-1 branch March 21, 2018 11:55
jamesmbourne pushed a commit to jamesmbourne/serverless-webpack that referenced this pull request Oct 15, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants