Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added Webpack 4 example #355

Merged
merged 1 commit into from
Mar 22, 2018
Merged

Added Webpack 4 example #355

merged 1 commit into from
Mar 22, 2018

Conversation

HyperBrain
Copy link
Member

@HyperBrain HyperBrain commented Mar 21, 2018

What did you implement:

Closes #XXXXX

Add example using Webpack 4. The example demonstrates the new settings in the webpack config as well as the new sls-webpack configuration layout in serverless.yml

How did you implement it:

How can we verify it:

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@HyperBrain HyperBrain added this to the 5.1.1 milestone Mar 22, 2018
@HyperBrain HyperBrain merged commit ad24e5c into master Mar 22, 2018
@HyperBrain HyperBrain deleted the webpack-4-example branch March 22, 2018 14:44
jamesmbourne pushed a commit to jamesmbourne/serverless-webpack that referenced this pull request Oct 15, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant