Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Regression Fix: Empty lines while stats: 'errors-only' #773

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

Enase
Copy link

@Enase Enase commented Apr 7, 2021

GENERAL:

Closes #499 #500

This is the regression fix.
Issue produced by #517 here

How did you implement it:

Do not print empty console messages in case if compiled item stats return nothing.

How can we verify it:

Setup webpack config with stats: 'errors-only' and run serverless deploy

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@j0k3r j0k3r added this to the 5.4.2 milestone Apr 7, 2021
Copy link
Member

@j0k3r j0k3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch and for providing (again) a fix!

@j0k3r j0k3r merged commit 30d7020 into serverless-heaven:master Apr 8, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty lines while stats: 'errors-only'
2 participants