Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update webpack version from 1.3.x to 2.2.1 #97

Closed

Conversation

AKIRA-MIYAKE
Copy link

@AKIRA-MIYAKE AKIRA-MIYAKE commented Feb 9, 2017

For complicated applications using type scripts, webpack 2 is more sophisticated and convenient.

@Gomah
Copy link

Gomah commented Feb 14, 2017

It's a breaking change, another PR #83 was just merged about it.

@domaslasauskas
Copy link
Contributor

domaslasauskas commented Feb 15, 2017

Good point @Gomah. I jumped the gun by merging #83 as looking at it now it was a breaking change too, I'll be reverting/replacing it with a version range instead. I'm planing to go through the backlog by fixing issues/taking pull requests over upcoming weeks.

@HyperBrain HyperBrain mentioned this pull request Jun 30, 2017
@HyperBrain
Copy link
Member

@domaslasauskas I'm planning to get out a stable update with the most needed fixes as soon as possible.
What is your opinion about the merged #83 . Although it might be a breaking change (as the including project has to specify a webpack version as peer dependency - we currently even use master with Webpack 3 without problems) I'm not really sure what side-effects or update problems might arise additionally.
Can you give a short statement about that?

@hassankhan
Copy link
Contributor

Not to disparage @AKIRA-MIYAKE's work, but is this PR relevant after #83? I'd be in favour of closing, since we can now specify what version we need ourselves.

@HyperBrain
Copy link
Member

Closing this, as the next release (v 2.0.0) adds Webpack as peer dependency and allows any Webpack version to be used.

@HyperBrain HyperBrain closed this Jul 2, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants