Skip to content
This repository was archived by the owner on Dec 9, 2024. It is now read-only.

Fix creating sync subscription for the same method and path #476

Merged
merged 1 commit into from
Jul 2, 2018

Conversation

mthenw
Copy link
Contributor

@mthenw mthenw commented Jul 2, 2018

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@codecov
Copy link

codecov bot commented Jul 2, 2018

Codecov Report

Merging #476 into master will increase coverage by 0.06%.
The diff coverage is 89.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #476      +/-   ##
==========================================
+ Coverage   70.66%   70.73%   +0.06%     
==========================================
  Files          35       35              
  Lines        2175     2180       +5     
==========================================
+ Hits         1537     1542       +5     
  Misses        574      574              
  Partials       64       64
Impacted Files Coverage Δ
internal/cache/target.go 0% <0%> (ø) ⬆️
libkv/subscription.go 88.75% <100%> (ø) ⬆️
internal/cache/subscription_cache.go 87.67% <95.65%> (+0.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24c3c35...b4ef44e. Read the comment docs.

@mthenw mthenw merged commit 60b4238 into master Jul 2, 2018
@mthenw mthenw deleted the fix-same-path-method branch July 2, 2018 09:48
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant