Skip to content
This repository was archived by the owner on Dec 9, 2024. It is now read-only.

Fix system event invocationFailed field name #487

Merged
merged 1 commit into from
Jul 24, 2018
Merged

Conversation

mthenw
Copy link
Contributor

@mthenw mthenw commented Jul 24, 2018

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: YES

@mthenw mthenw requested a review from sebito91 July 24, 2018 14:51
@mthenw mthenw force-pushed the fix-system-error branch from a7fff0c to 35fc2c8 Compare July 24, 2018 14:52
Copy link
Contributor

@sebito91 sebito91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm2

@codecov
Copy link

codecov bot commented Jul 24, 2018

Codecov Report

Merging #487 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #487   +/-   ##
=======================================
  Coverage   70.77%   70.77%           
=======================================
  Files          37       37           
  Lines        2190     2190           
=======================================
  Hits         1550     1550           
  Misses        576      576           
  Partials       64       64

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66f4c60...35fc2c8. Read the comment docs.

@mthenw mthenw merged commit f4be89f into master Jul 24, 2018
@mthenw mthenw deleted the fix-system-error branch July 24, 2018 15:03
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants