Skip to content

Support setting secrets with Secrets Manager #286

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
christophersjchow opened this issue Feb 7, 2022 · 3 comments
Closed

Support setting secrets with Secrets Manager #286

christophersjchow opened this issue Feb 7, 2022 · 3 comments
Labels
enhancement help wanted

Comments

@christophersjchow
Copy link
Contributor

Google introduced Secrets Manager support to functions in August last year. https://cloud.google.com/blog/products/serverless/cloud-functions-integrates-with-google-secret-manager

It would be great to be able to specify secrets within config to be pulled and set as env vars in functions.
@pgrzesik
Copy link
Contributor

pgrzesik commented Feb 7, 2022

Hello @christophersjchow - thanks for proposing, we'd be happy to accept a PR if someone is interested. 🙌

christophersjchow added a commit to christophersjchow/serverless-google-cloudfunctions that referenced this issue Feb 8, 2022
@christophersjchow
Add support for secrets manager environment variables
d14ab90 
Closes serverless#286
christophersjchow added a commit to christophersjchow/serverless-google-cloudfunctions that referenced this issue Feb 8, 2022
@christophersjchow
Add support for secrets manager environment variables
c93b0a6 
Closes serverless#286
christophersjchow added a commit to christophersjchow/serverless-google-cloudfunctions that referenced this issue Feb 8, 2022
@christophersjchow
Add support for secrets manager environment variables
5c81b7a 
Closes serverless#286
christophersjchow added a commit to christophersjchow/serverless-google-cloudfunctions that referenced this issue Feb 8, 2022
@christophersjchow
Add support for secrets manager environment variables
e4a0609 
Closes serverless#286
@christophersjchow
Copy link
Contributor Author

@pgrzesik i've raised 2 PRs, one here #287 and one for docs here serverless/serverless#10660

christophersjchow added a commit to christophersjchow/serverless-google-cloudfunctions that referenced this issue Feb 14, 2022
@christophersjchow
Add support for secrets manager environment variables
38eb21f 
Closes serverless#286
christophersjchow added a commit to christophersjchow/serverless-google-cloudfunctions that referenced this issue Feb 23, 2022
@christophersjchow
Add support for secrets manager environment variables
ef192df 
Closes serverless#286
christophersjchow added a commit to christophersjchow/serverless-google-cloudfunctions that referenced this issue Apr 28, 2022
@christophersjchow
Add support for secrets manager environment variables
5e094a5 
Closes serverless#286
@christophersjchow
Copy link
Contributor Author

Closed by #287

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pgrzesik @christophersjchow