refactor: Log child process command output on error #679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @zhemaituk - I believe I've fixed the CI issue, could you please rebase your branch against current |
A small addition to print out actual error details on child process failure. Refer to serverless#663 for issues details, when build fail for one or another reason, usually connected to configuration error and not library error, but no details are printed out.
|
@pgrzesik done |
pgrzesik
changed the title
jeanbmar
referenced
this pull request
Mar 3, 2022
…alled correctly. - Make sure we're consistently quoting arguments. - Add mergeCommands function to construct a script for docker to run when needed. - Add getStripMode to run strip correctly for the platform and docker.
|
@zhemaituk @pgrzesik this PR should be reverted and and stdio provided to spawn call. try {
await spawn(cmd, args, {
stdio: 'inherit',
}); |
|
Could you provide more explanation @jeanbmar? I'm not sure I understand the problem fully |
4 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small addition to print out actual error details on child process failure. Refer to #663 for issues details, when build fail for one or another reason, usually connected to configuration error and not library error, but no details are printed out.