#225 Update to Jakarta #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: radtriste <tradisso@redhat.com>
|
thanks for pr. will run some tests on it |
|
@radtriste can you please rebase it? |
ricardozanini
approved these changes
Oct 16, 2023
|
@manick02 do you mind taking a look? |
manick02
reviewed
Oct 18, 2023
|
Looks good to me, apart from a minor nit |
|
@manick02 @ricardozanini all updated |
manick02
approved these changes
Oct 20, 2023
Closed
|
I'll rebase and include this in a follow up 4.1.0 release supporting Java 11 and Jakarta. @manick02 @fjtirado @cdavernas wdyt? |
|
Ok |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
#225
What this PR does / why we need it:
With Jakarta introduced into Spring Boot and Quarkus 3, there is a need for projects to support Jakarta.
Special notes for reviewers:
I am not sure how to handle that. Should we have
*-jakartamodules of the sdk ?or a different version ?
Additional information (if needed):