-
Notifications
You must be signed in to change notification settings - Fork 48
[Fix_#514] Ignore nodes that only has required #515
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Signed-off-by: Francisco Javier Tirado Sarti <ftirados@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just a few comments regarding nomenclature as API
is indistinctly use as API
or Api
in names. Great work @fjtirado !
type: string | ||
title: WithAsyncAPIServer | ||
description: A a reference to the server to call the specified AsyncAPI operation on. If not set, default to the first server matching the operation's channel. | ||
title: AsyncApiProtocol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't API be capitalized as the others? AsyncAPIProtocol
title: WithAsyncAPIPayload | ||
description: The payload to call the AsyncAPI operation with, if any. | ||
$ref: '#/$defs/asyncApiOutboundMessage' | ||
title: AsyncApiMessage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
description: An object used to configure the message to publish using the target operation. | ||
subscription: | ||
$ref: '#/$defs/asyncApiSubscription' | ||
title: AsyncApiSubscription |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
description: The http call output format. Defaults to 'content'. | ||
enum: [ raw, content, response ] | ||
redirect: | ||
type: boolean | ||
title: HttpRedirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HTTPRedirect?
@@ -403,6 +416,10 @@ $defs: | |||
enum: [ raw, content, response ] | |||
title: WithOpenAPIOutput | |||
description: The http call output format. Defaults to 'content'. | |||
redirect: | |||
type: boolean | |||
title: HttpRedirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same
Fix #514