Skip to content

[Fix_#514] Ignore nodes that only has required #515

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

fjtirado
Copy link
Collaborator

Fix #514

Signed-off-by: Francisco Javier Tirado Sarti <ftirados@redhat.com>
Copy link
Contributor

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a few comments regarding nomenclature as API is indistinctly use as API or Api in names. Great work @fjtirado !

type: string
title: WithAsyncAPIServer
description: A a reference to the server to call the specified AsyncAPI operation on. If not set, default to the first server matching the operation's channel.
title: AsyncApiProtocol
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't API be capitalized as the others? AsyncAPIProtocol

title: WithAsyncAPIPayload
description: The payload to call the AsyncAPI operation with, if any.
$ref: '#/$defs/asyncApiOutboundMessage'
title: AsyncApiMessage
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

description: An object used to configure the message to publish using the target operation.
subscription:
$ref: '#/$defs/asyncApiSubscription'
title: AsyncApiSubscription
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

description: The http call output format. Defaults to 'content'.
enum: [ raw, content, response ]
redirect:
type: boolean
title: HttpRedirect
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTTPRedirect?

@@ -403,6 +416,10 @@ $defs:
enum: [ raw, content, response ]
title: WithOpenAPIOutput
description: The http call output format. Defaults to 'content'.
redirect:
type: boolean
title: HttpRedirect
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

@fjtirado fjtirado merged commit dd272e3 into serverlessworkflow:main Jan 15, 2025
2 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to latest version of the schema
3 participants