Skip to content

Use correct casing for workflows directory for tests. #51

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged

Conversation

ElanHasson
Copy link
Contributor

@ElanHasson ElanHasson commented Jan 3, 2024

Signed-off-by: Elan Hasson 234704+ElanHasson@users.noreply.github.com
Fixes #50.

Many thanks for submitting your Pull Request ❤️!

What this PR does / why we need it:
We need to be able to run tests on linux. This fixes the case sensitivity issue by using the same case as the file system.
Special notes for reviewers:

Additional information (if needed):

Signed-off-by: Elan Hasson <234704+ElanHasson@users.noreply.github.com>
@ElanHasson ElanHasson changed the title Fixes #50. Use correct casing for workflows directory for tests. Jan 3, 2024
Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Many thanks @ElanHasson ❤️

@cdavernas cdavernas merged commit 1642945 into serverlessworkflow:main Jan 4, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests fail when run on case-sensitive file systems
2 participants