Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add S-needs-code-changes if travis build fails #133

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wafflespeanut
Copy link
Contributor

@wafflespeanut wafflespeanut commented May 27, 2016

This is a rebase of #88.

@highfive
Copy link
Collaborator

Heads up! This PR modifies the following files:

  • @jdm: handlers/status_update/init.py, travisciapiprovider.py, eventhandler.py, handlers/status_update/tests/build_status.json, newpr.py

@highfive
Copy link
Collaborator

New code was committed to pull request.

@highfive
Copy link
Collaborator

New code was committed to pull request.

@highfive
Copy link
Collaborator

New code was committed to pull request.

@highfive
Copy link
Collaborator

New code was committed to pull request.

@highfive
Copy link
Collaborator

New code was committed to pull request.

@wafflespeanut wafflespeanut changed the title [WIP] Add S-needs-code-changes if travis build fails Add S-needs-code-changes if travis build fails May 29, 2016
@wafflespeanut
Copy link
Contributor Author

@jdm I'm not sure whether you're gonna like this, because I couldn't find a way to have a module for TravisCiApiProvider without a circular dependency (and test it at the same time) without duplicating code (especially because it should be initialized at extract_globals_from_payload).

The easier solution was to integrate extract_globals_from_payload and the travis payload parsing into APIProvider itself, so that we can reuse the methods whenever we want.

@bors-servo
Copy link

☔ The latest upstream changes (presumably #125) made this pull request unmergeable. Please resolve the merge conflicts.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants