First steps to allowing Linux to use EGL and OpenGLES #220

prashantgupta24 · 2015-12-07T04:46:53Z

…glDisplayInfo

…ImageKHR

glennw · 2015-12-07T12:51:58Z

Reviewed 2 of 4 files at r1, 3 of 3 files at r4.
Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

src/platform/egl/surface.rs, line 71 [r4] (raw file):
BGRA constant only exists on Linux - we'll need to apply the same trick I have done here (https://github.com/glennw/webrender/blob/master/src/device.rs#L16) to support BGRA on Linux and BGRA_EXT on Android.

src/platform/egl/surface.rs, line 85 [r4] (raw file):
Tabs -> spaces

Comments from the review on Reviewable.io

glennw · 2015-12-07T12:52:38Z

Just a few minor changes left - nearly there! :)

glennw · 2015-12-10T14:38:03Z

This looks good to me (well, it will still need a rebase + squash) - but I'd like to get @mrobinson to check over it too.

mrobinson · 2015-12-14T16:03:33Z

src/platform/linux/surface.rs

-            display: self.display,
-            visual_info: self.visual_info,
+        match *self {
+            NativeDisplay::Glx(info) => {


This should still be called GLX instead of Glx.

mrobinson · 2015-12-14T16:06:22Z

Looks good to me, apart from a few minor style and naming issues.

jdm · 2016-02-27T14:27:10Z

Rebased, squashed and comments addressed in #232.

Support EGL on non-Android Linux. Rebase and squash of #220.  [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-layers/232)

R00ney and others added 29 commits November 30, 2015 20:45

crate egl for both android/linux, add pub mod egl {}

a7ceb05

use egl::surface instead of android surface

9282815

make egl for struct and EGLImageNativeSurface

bdc7a46

add egl dependencies for linux

60e75e7

more stubs

bfa31b4

created a blank from_es2() function for ES2 render api function call

2252ee1

NativeDisplay to GlxDisplayInfo, new enum NativeDisplay, new struct E…

49ea03c

…glDisplayInfo

NativeDislpay

b4225a5

new NativeDislpay

1a1b2cf

fix typo

4ae78fa

fixed import isssue

0fa7612

changed NativeDisplay to import from linux and android, panic Destroy…

41c2a66

…ImageKHR

fixed paramater types of several functions to NativeDisplay

2006c19

fixed struct GlxDisplayInfo impl

5c004f9

added GlxDisplay breakout to upload and destroy

57fc573

pub structs

9a6e271

EGLImage for both linux/android

3d16dfd

native_surface_property linux or android for EGLImage

fbc96d6

NativeDisplay struct GlxDisplayInfo bindings fixed

b0e4430

fixed typo on line 69

dff0f87

fixed typo on line 62

d2fa780

fixed platform_display_data to unwrapped NativeDisplay enum

5dea68a

fixed redunt code and typo

b50d1ce

added from_es2

0443786

tricking linker with link extern...

132c7cc

unpanicked TexImage2D

bdc5d12

fixed import BGRA

5b3363f

made review comments

3ee9c48

Fixed extra spaces

cd78d85

fixed BGRA/BGRA_EXT for Linux/Android

c32236f

mrobinson reviewed Dec 14, 2015
View reviewed changes

gdamjan mentioned this pull request Dec 22, 2015

Wayland support servo/servo#332

Closed

larsbergstrom mentioned this pull request Dec 28, 2015

twis45 servo/blog.servo.org#50

Merged

jdm mentioned this pull request Feb 27, 2016

Support EGL on non-Android Linux. #232

Merged

jdm closed this Feb 27, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

First steps to allowing Linux to use EGL and OpenGLES #220

First steps to allowing Linux to use EGL and OpenGLES #220

prashantgupta24 commented Dec 7, 2015

glennw commented Dec 7, 2015

glennw commented Dec 7, 2015

glennw commented Dec 10, 2015

mrobinson Dec 14, 2015

mrobinson commented Dec 14, 2015

jdm commented Feb 27, 2016

First steps to allowing Linux to use EGL and OpenGLES #220

First steps to allowing Linux to use EGL and OpenGLES #220

Conversation

prashantgupta24 commented Dec 7, 2015

glennw commented Dec 7, 2015

glennw commented Dec 7, 2015

glennw commented Dec 10, 2015

mrobinson Dec 14, 2015

Choose a reason for hiding this comment

mrobinson commented Dec 14, 2015

jdm commented Feb 27, 2016