Deprecate unreachable function #164
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LunaBorowska
force-pushed
the
remove-unreachable-function
branch
from
38ab156 to
fdd2043
Compare
This is designed to merged after servo#162, as it deprecates a function that should be no longer necessary on newer Rust versions.
LunaBorowska
force-pushed
the
remove-unreachable-function
branch
from
fdd2043 to
dde0d8c
Compare
|
☔ The latest upstream changes (presumably #167) made this pull request unmergeable. Please resolve the merge conflicts. |
emilio
approved these changes
Oct 19, 2019
| #[inline] | ||
| #[deprecated(note = "Use std::hint::unreachable_unchecked instead")] |
There was a problem hiding this comment.
Given we're going to do a breaking version change, I'd rather just remove it.
emilio
pushed a commit
that referenced
this pull request
Oct 19, 2019
This is designed to merged after #162, as it deprecates a function that should be no longer necessary on newer Rust versions.
emilio
added a commit
that referenced
this pull request
Oct 19, 2019
Merged
dpc
pushed a commit
to dpc/rust-smallvec
that referenced
this pull request
Oct 30, 2019
This is designed to merged after servo#162, as it deprecates a function that should be no longer necessary on newer Rust versions.
dpc
pushed a commit
to dpc/rust-smallvec
that referenced
this pull request
Oct 30, 2019
mbrubeck
added a commit
to mbrubeck/rust-smallvec
that referenced
this pull request
Oct 30, 2019
* [breaking change] Use `MaybeUninit` internally to avoid possible undefined behavior (servo#162, servo#170). * [breaking change] The `drain` method now takes a range argument, just like the standard `Vec::drain` (servo#145). * [breaking change] Remove the `unreachable` function and replace it with the new standard `unreachable_unchecked` function (servo#164). * [breaking change] Use `no_std` by default. This crate depends only on `core` and `alloc` by default. If the optional `write` feature is enabled then it depends on `std` so that `SmallVec<[u8, _]>` can implement the `std::io::Write` trait (servo#173). * Add support for 96-element small vectors, `SmallVec<[T; 96]>` (servo#163). * Iterators now implement `FusedIterator` (servo#172). * Indexing now uses the standard `SliceIndex` trait (servo#166). * Remove the deprecated `VecLike` trait (servo#165). * Use `NonNull` internally (servo#171). * Add automatic fuzz testing and MIRI testing (servo#168, servo#162). * Update syntax and formatting to Rust 2018 standard (servo#174, servo#167).
Merged
bors-servo
pushed a commit
that referenced
this pull request
Nov 2, 2019
Version 1.0.0 * Requires Rust 1.36 or later. * [breaking change] Use `MaybeUninit` to avoid possible undefined behavior (#162, #170). * [breaking change] The `drain` method now takes a range argument, just like the standard `Vec::drain` (#145). * [breaking change] Remove the `unreachable` function and replace it with the new standard `unreachable_unchecked` function (#164). * [breaking change] Use `no_std` by default. This crate depends only on `core` and `alloc` by default. If the optional `write` feature is enabled then it depends on `std` so that `SmallVec<[u8;_]>` can implement the `std::io::Write` trait (#173). * Add support for 96-element small vectors, `SmallVec<[T; 96]>` (#163). * Iterators now implement `FusedIterator` (#172). * Indexing now uses the standard `SliceIndex` trait (#166). * Remove the deprecated `VecLike` trait (#165). * Use `NonNull` internally (#171). * Add automatic fuzz testing and MIRI testing (#168, #162). * Update syntax and formatting to Rust 2018 standard (#174, #167).
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is designed to merged after #162, as it deprecates a function that should be no longer necessary on newer Rust versions.
This change is