Skip to content

Use min_const_generics #232

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2020
Merged

Use min_const_generics #232

merged 1 commit into from
Aug 11, 2020

Conversation

c410-f3r
Copy link
Contributor

@c410-f3r c410-f3r commented Aug 9, 2020

No description provided.

@jdm
Copy link
Member

jdm commented Aug 9, 2020 

error[E0658]: const generics are unstable

    --> src/lib.rs:1910:22

     |

1910 | unsafe impl<T, const N: usize> Array for [T; N] {

     |                      ^

     |

     = note: see issue #44580 <https://github.com/rust-lang/rust/issues/44580> for more information

     = help: add `#![feature(const_generics)]` to the crate attributes to enable

@jdm
Copy link
Member

jdm commented Aug 9, 2020

That failure occurs as part of this command.

@mbrubeck
Copy link
Collaborator

We'll need to wait for a newer nightly that includes miri.

@mbrubeck
Copy link
Collaborator

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 0e23d2a has been approved by mbrubeck

@bors-servo
Copy link
Contributor

⌛ Testing commit 0e23d2a with merge 87500c3...

@bors-servo
Copy link
Contributor

☀️ Test successful - checks-travis
Approved by: mbrubeck
Pushing 87500c3 to master...

@bors-servo bors-servo merged commit 87500c3 into servo:master Aug 11, 2020
mbrubeck added a commit to mbrubeck/rust-smallvec that referenced this pull request Aug 11, 2020
@mbrubeck
Version 1.4.2
ba0f462 
* `insert_many` no longer leaks elements if the provided iterator panics (servo#213).
* The unstable `const_generics` and `specialization` features are
  updated to work with the most recent nightly Rust toolchain (servo#232).
* Internal code cleanup (servo#229, servo#231).
@mbrubeck mbrubeck mentioned this pull request Aug 11, 2020
Merged
bors-servo added a commit that referenced this pull request Aug 11, 2020
@bors-servo
Auto merge of #233 - mbrubeck:bump, r=jdm
9ae7076 
Version 1.4.2

Changelog:

* `insert_many` no longer leaks elements if the provided iterator panics (#213).
* The unstable `const_generics` and `specialization` features are updated to work with the most recent nightly Rust toolchain (#232).
* Internal code cleanup (#229, #231).

This PR also changes the `author` field in `Cargo.toml` to "The Servo Project Developers".
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@c410-f3r @jdm @mbrubeck @bors-servo