Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make sure a windows drive letter segment always ends with a slash. #538

Closed
wants to merge 1 commit into from

Conversation

o0Ignition0o
Copy link
Contributor

@o0Ignition0o o0Ignition0o commented Aug 5, 2019

This is supposed to fix #505


This change is Reviewable

@o0Ignition0o o0Ignition0o changed the title Make sure a windows drive letter segment always ends with a slash. WIP Make sure a windows drive letter segment always ends with a slash. Aug 5, 2019
@o0Ignition0o o0Ignition0o changed the title WIP Make sure a windows drive letter segment always ends with a slash. Make sure a windows drive letter segment always ends with a slash. Aug 5, 2019
@nox
Copy link
Contributor

nox commented Aug 19, 2019

Is this PR still relevant?

@o0Ignition0o
Copy link
Contributor Author

It is, but it might be wiser to merge it with #537

@nox
Copy link
Contributor

nox commented Aug 20, 2019

Yes.

@nox nox closed this Aug 20, 2019
@o0Ignition0o o0Ignition0o deleted the to_file_path_panic branch August 22, 2019 09:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

windows: to_file_path() panics for certain URLs created by from_file_path()
2 participants