Skip to content

Deprecate Origin unicode_serialization (and bump the url version) #917

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

evilpie
Copy link

@evilpie evilpie commented Mar 23, 2024

Fixes #881

@micolous
Copy link
Contributor

micolous commented Apr 3, 2024

FYI #887 already fixed this and other deprecations – that's was just blocked on #886 to run wasm32 tests in CI.

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@73803fa). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #917   +/-   ##
=======================================
  Coverage        ?   81.77%           
=======================================
  Files           ?       20           
  Lines           ?     3551           
  Branches        ?        0           
=======================================
  Hits            ?     2904           
  Misses          ?      647           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mark Origin::unicode_serialization as deprecated?
2 participants