Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Osmesa Backend #65

Merged
merged 2 commits into from
Sep 21, 2016
Merged

Osmesa Backend #65

merged 2 commits into from
Sep 21, 2016

Conversation

emilio
Copy link
Member

@emilio emilio commented Sep 20, 2016

No description provided.

@emilio
Copy link
Member Author

emilio commented Sep 20, 2016

Sorry for not finishing this, @glennw, I have a OSMesa back-end integration WIP somewhere, but I couldn't finish it today (to many other compromises :/).

I just didn't want you to do this work in duplicate. Also, note that choosing a non-core backend is intentional, in my tests sharing works fine with these, but we can add the necessary code to WebGL to handle core profiles properly.

r? @glennw

@emilio
Copy link
Member Author

emilio commented Sep 20, 2016

Note that I need to add the osmesa packages or something so our CI passes again, but that's not relevant to the core of this PR.

@glennw
Copy link
Member

glennw commented Sep 20, 2016

@emilio Looks good to me. I think the CI issue is that travis uses Ubuntu 14.04 which has an old version of OSMesa that doesn't include the symbols we use.

I have a source package of OSMesa that builds via cargo here https://github.com/glennw/osmesa-src. We could add that as a dependency and set the env vars to the location of that to allow testing.

We could land it with the OSMesa test disabled for now, and add the source build of OSMesa above later, perhaps?

@glennw
Copy link
Member

glennw commented Sep 21, 2016

I've been testing this locally today and it's working well.

r=me once the version number is bumped and we decide what to do about the linux + travis test issue.

@emilio
Copy link
Member Author

emilio commented Sep 21, 2016

I made a quick try to enable CI and ran into linker errors for an old LLVM version. Opened #66 to track it.

@emilio
Copy link
Member Author

emilio commented Sep 21, 2016

Merging this since this goes untested anyway.

@emilio emilio merged commit 07fea78 into master Sep 21, 2016
@emilio emilio deleted the osmesa branch September 21, 2016 20:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants