Skip to content

A bit cleanup of NEXT_NAMESPACE_ID #3127

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Sep 26, 2018
Merged

Conversation

sotaroikeda
Copy link
Contributor

@sotaroikeda sotaroikeda commented Sep 26, 2018

Initialization becomes simpler with AtomicUsize::new(1).


This change is Reviewable

@gw3583
Copy link
Contributor

gw3583 commented Sep 26, 2018

I think it used to be this way due to a restriction in rustc. Is the minimum rustc version required by Gecko sufficient to support this change now?

@sotaroikeda
Copy link
Contributor Author

Ah, I recalled #1882 (comment).

feature(const_atomic_usize_new) was already removed by rust-lang/rust#46287. And AtomicUsize::new(1) is stabilized API and could be used on gecko.

https://gitlab.redox-os.org/redox-os/rust/commit/28b39f5d7aec44176b06fbbad0d5fc6e711d28f3?view=inline&w=1#efb3a8f27841e02c096caf40976056107478ba0e_1_42

@gw3583
Copy link
Contributor

gw3583 commented Sep 26, 2018

@bors-servo r+

Thanks!

@bors-servo
Copy link
Contributor

📌 Commit 6e85020 has been approved by gw3583

@bors-servo
Copy link
Contributor

⌛ Testing commit 6e85020 with merge a0779f2...

bors-servo pushed a commit that referenced this pull request Sep 26, 2018
A bit cleanup of NEXT_NAMESPACE_ID

Initialization becomes simpler with AtomicUsize::new(1).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3127)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: gw3583
Pushing a0779f2 to master...

@bors-servo bors-servo merged commit 6e85020 into servo:master Sep 26, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants