A bit cleanup of NEXT_NAMESPACE_ID #3127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it used to be this way due to a restriction in rustc. Is the minimum rustc version required by Gecko sufficient to support this change now? |
|
Ah, I recalled #1882 (comment). feature(const_atomic_usize_new) was already removed by rust-lang/rust#46287. And AtomicUsize::new(1) is stabilized API and could be used on gecko. |
|
@bors-servo r+ Thanks! |
|
📌 Commit 6e85020 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Sep 26, 2018
A bit cleanup of NEXT_NAMESPACE_ID Initialization becomes simpler with AtomicUsize::new(1). <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3127) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-taskcluster |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initialization becomes simpler with AtomicUsize::new(1).
This change is