Skip to content

[WIP] Avoid copies of large picture primitives during flattening #3360

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[WIP] Avoid copies of large picture primitives during flattening #3360

wants to merge 1 commit into from

Conversation

kvark
Copy link
Member

@kvark kvark commented Nov 27, 2018 •
edited by larsbergstrom
Loading

Addresses some of the bigger #3358 parts related to PicturePrimitive. Adds the basic push_with helper to vectors that avoid copy (kudos to @jrmuizel ).
TODO:

  • verify that the copies are gone (need the tool hosted/opened somewhere)
  • rebase
  • Gecko try push with talos jobs

This change is Reviewable

@kvark kvark requested a review from jrmuizel November 27, 2018 17:48
@kvark kvark changed the title Avoid copies of large picture primitives during flattening [WIP] Avoid copies of large picture primitives during flattening Nov 27, 2018
@kvark kvark mentioned this pull request Nov 27, 2018
Merged
@kvark
Copy link
Member Author

kvark commented Nov 27, 2018

Closing in favor of a prettier #3362

@kvark kvark closed this Nov 27, 2018
@kvark kvark deleted the picture-copies branch November 27, 2018 20:42
bors-servo pushed a commit that referenced this pull request Nov 28, 2018
Auto merge of #3362 - kvark:picture-copies2, r=jrmuizel
be65949 
Avoid picture primitive copies via VecHelper

This is a successor of #3360 that avoids the borrow checker dance via RAII
Addresses part of #3358

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3362)
<!-- Reviewable:end -->
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jrmuizel jrmuizel Awaiting requested review from jrmuizel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kvark